Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update utilites.ts to cover null case #5110

Merged
merged 6 commits into from
Sep 4, 2019
Merged

Update utilites.ts to cover null case #5110

merged 6 commits into from
Sep 4, 2019

Conversation

lifeiscontent
Copy link
Contributor

@lifeiscontent lifeiscontent commented Jul 31, 2019 •
edited
Loading

  • fix edge case when data is resolved to null

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@lifeiscontent
Copy link
Contributor Author

@benjamn can I get a review? :)

hwillson
hwillson approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @lifeiscontent!

@hwillson hwillson merged commit c5d5c8d into apollographql:master Sep 4, 2019
@snyk-bot snyk-bot mentioned this pull request Jan 17, 2020
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CarloPalinckx CarloPalinckx CarloPalinckx left review comments

@hwillson hwillson hwillson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lifeiscontent @hwillson @CarloPalinckx