Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subscribeToMore to recognize fetch policy #5114

Closed

Conversation

nuragic
Copy link

@nuragic nuragic commented Aug 1, 2019

The subscribeToMore was missing the fetchPolicy option. I dunno if it's a bug or a feature... I think it's a missing piece of #3773.

Let me know in case there's need to add new tests. I guess it should also be documented before merging.

Thanks! 🚀

@nuragic nuragic changed the title Adjust subscribetoMore to recognize fetch policy Adjust subscribeToMore to recognize fetch policy Aug 1, 2019
@hwillson hwillson added this to the Post 3.0 milestone Sep 4, 2019
@nuragic
Copy link
Author

nuragic commented Oct 3, 2019

Hi @hwillson! Do you think this one could land in v3? That would be great, because to have this fix we're using a fork of mine currently... and we would prefer to switch to apollo master branch again! 😄 Thanks!

@nuragic nuragic force-pushed the fix-fetchPolicy-subscribeToMore branch from 3f6a99f to 4b1390f Compare January 15, 2020 09:22
@nuragic nuragic changed the title Adjust subscribeToMore to recognize fetch policy Fix subscribeToMore to recognise fetch policy Jan 15, 2020
@nuragic nuragic changed the title Fix subscribeToMore to recognise fetch policy Fix subscribeToMore to recognize fetch policy Jan 15, 2020
@nuragic
Copy link
Author

nuragic commented Jan 15, 2020

Just rebased with master, hope it could land in v3 @hwillson @benjamn

@hwillson
Copy link
Member

hwillson commented Jun 1, 2021

Thanks very much for working on this. We don't think supporting all fetch policies necessarily makes sense with subscriptions. If we revisit this we should figure out exactly what each policy means for subscriptions, and whether any additional policies are needed specifically for subscriptions. Thanks again!

@hwillson hwillson closed this Jun 1, 2021
@nuragic
Copy link
Author

nuragic commented Jun 1, 2021

@hwillson Hi! You're welcome. It's been a long time since this PR... cool, honestly I think it would be not ideal to have a fetchPolicy on subscriptions... however, my concern is about the cache: is the default policy for subscriptions right now "no-cache"? Because I think it doesn't make sense to cache real time data, since it will be cached within the associated Query...

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants