fix: catch errors thrown by cache when reading query result #5294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue reported in apollographql/react-apollo#3367 (also reproduced here: https://github.com/noahm/react-apollo-error-template/tree/skip-with-directive-error)
After sleuthing around a bit I found the issue was introduced by #4743 in
apollo-cache@2.6.0-beta.7
as a result of removing the try-catch statement around the attempt to read from the cache. I'm not terribly familiar with the Apollo codebase, and perhaps a fix for this is better suited as a tweak inreact-apollo
or perhaps inside the cache layer itself, but the issue is blocking our ability to upgrade.Checklist:
If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)(n/a)