Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore directives for variable usages in query merging #584

Merged
merged 3 commits into from
Aug 30, 2016
Merged

Explore directives for variable usages in query merging #584

merged 3 commits into from
Aug 30, 2016

Conversation

rricard
Copy link
Contributor

@rricard rricard commented Aug 24, 2016 •
edited
Loading

Fixes #577

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)

rricard added a commit that referenced this pull request Aug 24, 2016
@rricard
Add to changelog the changes by #584
b9ec1e2
@rricard rricard added ready and removed in progress labels Aug 24, 2016
@rricard
Copy link
Contributor Author

rricard commented Aug 24, 2016

Size tests are failing, maybe we should add a kB, I think we are on the edge here...

@rricard rricard mentioned this pull request Aug 24, 2016
Closed
@rricard rricard self-assigned this Aug 24, 2016
@rricard rricard mentioned this pull request Aug 24, 2016
Closed
@stubailo
Copy link
Contributor

Can you rebase? We added a kB in another patch.

rricard added a commit that referenced this pull request Aug 25, 2016
@rricard
Add to changelog the changes by #584
5d3cbb0
@rricard
Copy link
Contributor Author

rricard commented Aug 25, 2016

done!

helfer pushed a commit that referenced this pull request Aug 30, 2016
@rricard @helfer
Add to changelog the changes by #584
3d34e1e
@helfer helfer self-assigned this Aug 30, 2016
rricard added 3 commits August 30, 2016 15:47
@rricard @helfer
Add failing test reproducing #577
faceb33 
Query merging should be able to merge queries with variables in directives correctly:

tests if the variables in a directive are correctly merged.
@rricard @helfer
Fix #577 by exploring directives for renaming
9936d15 
In query merging, explore directives for varaiable usage and rename effectively the variables.
@rricard @helfer
Add to changelog the changes by #584
722afe9
@helfer
Copy link
Contributor

helfer commented Aug 30, 2016

Cool, thanks a lot!

@helfer helfer merged commit 04dc479 into master Aug 30, 2016
@helfer helfer removed the ready label Aug 30, 2016
@rricard rricard deleted the fix-577 branch August 30, 2016 22:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rricard rricard

@helfer helfer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rricard @stubailo @helfer @zol