Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If there are no optimistic updates to apply, return immediately. #597

Merged
merged 1 commit into from
Aug 30, 2016
Merged

If there are no optimistic updates to apply, return immediately. #597

merged 1 commit into from
Aug 30, 2016

Conversation

dahjelle
Copy link
Contributor

TODO:

  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change

@dahjelle
Copy link
Contributor Author

I happened to notice this as I was doing some profiling of our application; it made a pretty big difference since we aren't using the optimistic updates features at all.

@dahjelle dahjelle force-pushed the short-circuit-when-no-optimistic-updates branch from ce67fd4 to 4e222ba Compare August 29, 2016 18:24
@stubailo stubailo self-assigned this Aug 30, 2016
@stubailo stubailo merged commit 74eda47 into apollographql:master Aug 30, 2016
@stubailo
Copy link
Contributor

Wonderful!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@stubailo stubailo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dahjelle @stubailo