Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overridable options in network layer for middleware #628

Merged
merged 2 commits into from
Sep 9, 2016
Merged

Overridable options in network layer for middleware #628

merged 2 commits into from
Sep 9, 2016

Conversation

rricard
Copy link
Contributor

@rricard rricard commented Sep 9, 2016 •
edited
Loading

Fixes #627

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)

@zol zol added the in progress label Sep 9, 2016
@rricard rricard force-pushed the middleware-network-override branch from 0131d06 to 877ea0b Compare September 9, 2016 16:15
@stubailo
Copy link
Contributor

stubailo commented Sep 9, 2016

Looks right to me, thanks!

@stubailo stubailo merged commit a92631d into master Sep 9, 2016
@rricard rricard deleted the middleware-network-override branch September 11, 2016 14:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rricard @stubailo @zol