-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge QueryBaseOptions, QueryOptions, and ModifiableQueryOptions into one type. #7136
Conversation
@DCtheTall: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
This PR fixes #6177 |
@hwillson friendly ping 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement, @DCtheTall!
I changed the target branch to release-3.3
just because the removal of QueryBaseOptions
(which was exported) could theoretically be a disruptive change, but I don't anticipate that being a problem for many people, and the fix is easy (just use QueryOptions
instead).
@benjamn totally understand/agree. I did a search on GitHub for its usage and found it is used virtually nowhere, but I can understand the desire to gate a potentially breaking change behind a release. |
Checklist: