-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove query whitespace, take 2: Function Time #8699
Remove query whitespace, take 2: Function Time #8699
Conversation
@sarahghp: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
@benjamn Do you mind taking a look at this draft and confirming the approach matches expectations? Then I'll go in and add new specs and docs, update filesize, etc. Thanks! |
bc55764
to
82e41b6
Compare
@benjamn @StephenBarlow This is ready for feedback on specs and docs now. Thank you! |
53d9ed2
to
bdc0733
Compare
05f8c76
to
5283433
Compare
5283433
to
c552a44
Compare
c552a44
to
93f891e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding tests and docs!
I rebased against release-3.5
(since this is technically new functionality), and I expect to release these changes in @apollo/client@3.5.0-beta.11
(the next beta release).
I'll let @StephenBarlow review these documentation changes asynchronously.
Implements approach for optionally removing removing whitespace or otherwise passing custom print functions to
HttpLink
and friends as outlined in #8549.Checklist: