Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a misplaced semicolon #9498

Merged
merged 2 commits into from
May 11, 2022
Merged

Fix a misplaced semicolon #9498

merged 2 commits into from
May 11, 2022

Conversation

mlocher
Copy link
Contributor

@mlocher mlocher commented Mar 8, 2022

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@mlocher mlocher requested a review from StephenBarlow as a code owner March 8, 2022 12:39
@apollo-cla
Copy link

@mlocher: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

jpvajda
jpvajda approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@jpvajda jpvajda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch here, and this is a good standard in Javascript to have a trailing comma Thanks for the contribution!

@jpvajda jpvajda self-assigned this May 11, 2022
@jpvajda jpvajda merged commit 293af71 into apollographql:main May 11, 2022
@mlocher mlocher deleted the patch-1 branch May 18, 2022 17:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jpvajda jpvajda jpvajda approved these changes

@StephenBarlow StephenBarlow Awaiting requested review from StephenBarlow

Assignees

@jpvajda jpvajda

Labels
📝 documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlocher @apollo-cla @jpvajda