Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch fetchQuery errors in startQuery. #950

Merged
merged 3 commits into from
Nov 28, 2016
Merged

Catch fetchQuery errors in startQuery. #950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12901e0
Catch `fetchQuery` promise errors in `startQuery`.
Nov 23, 2016
54d03eb
Update AUTHORS and CHANGELOG for #950
Nov 23, 2016
91b9619
Merge branch 'master' into patch-1
helfer Nov 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ Louis DeScioli <louis@grovelabs.io>
Marc-Andre Giroux <mgiroux0@gmail.com>
Martijn Walraven <martijn@martijnwalraven.com>
Maxime Quandalle <maxime@quandalle.com>
Michiel ter Reehorst <michiel@jamiter.com>
Oleksandr Stubailo <sashko@Oleksandrs-MacBook-Pro.local>
Olivier Ricordeau <olivier@ricordeau.org>
Pavol Fulop <pavol.fulop@regex.sk>
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ Expect active development and potentially significant breaking changes in the `0

### vNEXT

- Catch uncaught promise errors in QueryManager [#950](https://github.com/apollostack/apollo-client/pull/950)

### 0.5.6
- Refactor polling query logic to fix startPolling and stopPolling [#938](https://github.com/apollostack/apollo-client/pull/938)
- Add convenience method to obtain initial state from SSR [#941](https://github.com/apollostack/apollo-client/pull/941)
Expand Down
5 changes: 4 additions & 1 deletion src/core/QueryManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,10 @@ export class QueryManager {
public startQuery(queryId: string, options: WatchQueryOptions, listener: QueryListener) {
this.addQueryListener(queryId, listener);

this.fetchQuery(queryId, options);
this.fetchQuery(queryId, options)
// `fetchQuery` returns a Promise. In case of a failure it should be caucht or else the
// console will show an `Uncaught (in promise)` message. Ignore the error for now.
.catch((error: Error) => undefined);

return queryId;
}
Expand Down