Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a comment about a new use of the content-type header #9683

Merged
merged 1 commit into from
May 5, 2022
Merged

Add a comment about a new use of the content-type header #9683

merged 1 commit into from
May 5, 2022

Conversation

glasser
Copy link
Member

@glasser glasser commented May 5, 2022

No description provided.

benjamn
benjamn approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems consistent with the docs you linked to, so LGTM.

Thanks @glasser!

@benjamn benjamn merged commit dc3cabb into main May 5, 2022
@benjamn benjamn deleted the glasser/csrf-prevention-client branch May 5, 2022 18:11
@glasser
Copy link
Member Author

glasser commented May 5, 2022

Funny story: the person responsible for not understanding that we probably shouldn't include content-type with GETs (which worked out well for us in the end) was... me, in one of my few client changes ever. apollographql/apollo-link#490

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjamn benjamn benjamn approved these changes

Assignees
No one assigned
Labels
🔗 apollo-link 📝 documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glasser @benjamn