Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gqlgen implementation #42

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Conversation

kdawgwilk
Copy link
Contributor

@kdawgwilk kdawgwilk commented Oct 21, 2021

Closes #17

@@ -9,6 +9,7 @@ The following open-source GraphQL server libraries provide support for Apollo Fe
| Language | Framework | _service | @key (single) | @key (multi) | @key (composite) | @requires | @provides | ftv1 |
| --- | --- | --- | --- | --- | --- | --- | --- | --- |
| Elixir | [absinthe_federation](https://github.com/DivvyPayHQ/absinthe_federation) | ✔️ | ✔️ | ✔️ | ✔️ | ✔️ | ✔️ | ❌ ([coming soon](https://github.com/DivvyPayHQ/absinthe_federation/pull/25)) |
| Go | [gqlgen](https://gqlgen.com/) | ✔️ | ✔️* | ✔️* | ❌ | ✔️ | ✔️ | ❌ |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, gqlgen does not support multiple @key directives per entity, but I may try to put a PR together for it

Copy link
Contributor Author

@kdawgwilk kdawgwilk Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that is what the * is for, it means that it supports @key(fields: "id")(single) or @key(fields: "sku package") (multi) but not @key(fields: "id") @key(fields: "sku package") together at the same time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also looks like support for @key (composite) just merged in the last 24hrs 🎉 Once that has been tagged we can update this to reflect that support

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, @key (multi) has been merged as well (not part of a release yet).

@LockedThread
Copy link

@kdawgwilk Man, you're a life saver. This is exactly what I needed right now.

@michael-watson michael-watson marked this pull request as ready for review November 16, 2021 17:20
@michael-watson michael-watson merged commit 772bfae into apollographql:main Nov 16, 2021
@kdawgwilk kdawgwilk deleted the kaden/gqlgen branch November 19, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GO Federation Compatibility Testing Support - gqlgen
4 participants