fix Array JSONEncodable #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm... I wanted to do this ages ago, and there was some reason why I couldn't. I think it was causing some build errors. We're going to need to test this manually on iOS versions pre 14.4. I'm wondering if the issues I saw before had to do with the conversion of the nested Thanks for the PR. Give me some time to look into this a bit further before we pull it in. |
|
Do you need help with something? |
👷 Deploy request for apollo-ios-docc pending review.Visit the deploys page to approve it
|
👷 Deploy request for eclectic-pie-88a2ba pending review.Visit the deploys page to approve it
|
calvincestari
approved these changes
Jul 29, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Jul 29, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Jul 29, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Jul 29, 2024
9d0bb802 fix Array JSONEncodable (#128) git-subtree-dir: apollo-ios git-subtree-split: 9d0bb802d9eb8aaa9ede384461824779807dff0b
BobaFetters
pushed a commit
that referenced
this pull request
Jul 29, 2024
git-subtree-dir: apollo-ios git-subtree-mainline: 745fdc9 git-subtree-split: 9d0bb802d9eb8aaa9ede384461824779807dff0b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using fatal error on
JSONEncodableinstead of conforming protocol with where clause