Added Existential Any requirement #379
Merged
+1,440
−1,110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
There was a problem hiding this comment.
Looks good, a couple questions:
- Should we standardize on
swift-tools-versionof5.9across all packages in the repo? Eg:apollo-ios-paginationstill on5.8. - I think we should get the
ExistentialAnysetting into the codegen test configuration projects too. Knowing those build correctly will be valuable.
I think it makes sense to standardize this across our packages.
+1 |
AnthonyMDev
force-pushed
the
existential-any
branch
from
c033f6b to
a3b8905
Compare
Merged
calvincestari
approved these changes
Jun 5, 2024
| @@ -704,6 +704,7 @@ | |||
| MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE; | |||
| MTL_FAST_MATH = YES; | |||
| ONLY_ACTIVE_ARCH = YES; | |||
| OTHER_SWIFT_FLAGS = "\"-enable-upcoming-feature ExistentialAny\""; | |||
There was a problem hiding this comment.
Doesn't this one need the enclosing " removed too? There is one more at L763 that has them too.
BobaFetters
pushed a commit
that referenced
this pull request
Jun 6, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Jun 6, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Jun 6, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios-pagination
that referenced
this pull request
Jun 6, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Jun 6, 2024
3188d6a6 Added Existential Any requirement (#379) git-subtree-dir: apollo-ios git-subtree-split: 3188d6a60184e826ac51a526d35a362aeba2cb9d
BobaFetters
pushed a commit
that referenced
this pull request
Jun 6, 2024
git-subtree-dir: apollo-ios git-subtree-mainline: 94be720 git-subtree-split: 3188d6a60184e826ac51a526d35a362aeba2cb9d
BobaFetters
pushed a commit
that referenced
this pull request
Jun 6, 2024
d48baeb7 Added Existential Any requirement (#379) git-subtree-dir: apollo-ios-codegen git-subtree-split: d48baeb705e8ede2247e8ebbf2fae5c6fd0430df
BobaFetters
pushed a commit
that referenced
this pull request
Jun 6, 2024
git-subtree-dir: apollo-ios-codegen git-subtree-mainline: 64a1859 git-subtree-split: d48baeb705e8ede2247e8ebbf2fae5c6fd0430df
BobaFetters
pushed a commit
that referenced
this pull request
Jun 6, 2024
8e073198 Added Existential Any requirement (#379) git-subtree-dir: apollo-ios-pagination git-subtree-split: 8e073198d8bc2a206dc6e886aa9efd9dba9f9f81
BobaFetters
pushed a commit
that referenced
this pull request
Jun 6, 2024
…ement git-subtree-dir: apollo-ios-pagination git-subtree-mainline: 40eb7b6 git-subtree-split: 8e073198d8bc2a206dc6e886aa9efd9dba9f9f81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
-enable-upcoming-feature ExistentialAnyflag to all targets in the project and adds theanykeyword at all necessary call sites.The code generation templates are also updated to add the
anykeyword where needed.