-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Schema Type Renaming #388
Merged
Merged
+2,207
−422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anthony Miller <anthonymdev@gmail.com>
Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com>
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
✅ Deploy Preview for apollo-ios-docc canceled.
|
calvincestari
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the commit list it looks like this is the three PRs we've reviewed already right? That and the merges frommain
. LGTM!
BobaFetters
added a commit
that referenced
this pull request
Jun 13, 2024
BobaFetters
added a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Jun 13, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Jun 13, 2024
d4eaa545 Feature: Schema Type Renaming (#388) git-subtree-dir: apollo-ios-codegen git-subtree-split: d4eaa5457e0b3f0f4b42671d16efe1f649003398
BobaFetters
pushed a commit
that referenced
this pull request
Jun 13, 2024
git-subtree-dir: apollo-ios-codegen git-subtree-mainline: f05a29f git-subtree-split: d4eaa5457e0b3f0f4b42671d16efe1f649003398
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the finished schema type renaming feature that was done across multiple PRs, ready to be merged into main.
Work is from the following PRs:
Closes apollographql/apollo-ios#3283