fix: ObjectData type check
#459
Merged
+98
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvincestari
changed the title
ObjectData Int/Bool value check
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
calvincestari
changed the title
ObjectData Int/Bool value checkObjectData type check
|
Putting this into draft since I realized it can't use the static constants due to being a public function. |
|
I can't think of a better non-intrusive way to fix this. The static constants needed to be made public because the |
AnthonyMDev
approved these changes
Aug 13, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Aug 13, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Aug 13, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Aug 13, 2024
1da33d37 fix: `ObjectData` type check (#459) 65d7a19e Update ROADMAP.md git-subtree-dir: apollo-ios git-subtree-split: 1da33d37db8fadaa426e3d2493a9dbddb4617308
BobaFetters
pushed a commit
that referenced
this pull request
Aug 13, 2024
git-subtree-dir: apollo-ios git-subtree-mainline: dd2193b git-subtree-split: 1da33d37db8fadaa426e3d2493a9dbddb4617308
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apollographql/apollo-ios#3414
Checking whether
AnyHashablecan be cast to aBoolis not enough to infer behaviour from the original type. The only way to do that is to compare against the two possibleBoolvalues;trueandfalse. This is possible because of the wayAnyHashabledoes equality comparison.