Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bug with AnyHashable coercion for non-iOS platforms #517

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

VMLe
Copy link
Contributor

@VMLe VMLe commented Oct 23, 2024

We encountered a similar issue on the macOS 11..<11.3 versions, which has been fixed for iOS.

Although the issue was observed on macOS, I suggest including all platforms that could potentially face the same problem.


This PR extends the _AnyHashableCanBeCoerced check to include macOS, watchOS, and tvOS with their respective minimum versions.


@apollo-cla
Copy link

@VMLe: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

netlify bot commented Oct 23, 2024

👷 Deploy request for apollo-ios-docc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit bc28307

Copy link

netlify bot commented Oct 23, 2024

👷 Deploy request for eclectic-pie-88a2ba pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit bc28307

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Oct 23, 2024

✅ Docs Preview Ready

No new or changed pages found.

@AnthonyMDev
Copy link
Contributor

Thank you for this! I'm happy to accept this PR. Just want to make sure we have the correct versions for each platform. Where did you get the versions that you added to the check for each platform from? This behavior of AnyHashable isn't well documented, and I want to make sure we are getting it right.

@VMLe
Copy link
Contributor Author

VMLe commented Oct 23, 2024

I can confirm that for macOS, AnyHashable coercion starts working correctly with macOS 11.3, based on the data we get from Sentry and our observations.

Also, all the versions I mentioned, including iOS 14.5, are related to Xcode 12.5 and have similar release dates and release notes. ( macOS, iOS, watchOS, tvOS )

However, you are correct — Apple does not provide any information about this issue. Consequently, I do not have confirmation for tvOS and watchOS due to the lack of available data.

I believe that all these versions are closely related. However, if you feel that the connection between these versions is insufficient, I can remove watchOS and tvOS from this pull request.

@AnthonyMDev AnthonyMDev merged commit d430e83 into apollographql:main Oct 24, 2024
28 checks passed
BobaFetters pushed a commit to apollographql/apollo-ios that referenced this pull request Oct 24, 2024
BobaFetters pushed a commit that referenced this pull request Oct 24, 2024
79187048 fix: Bug with AnyHashable coercion for non-iOS platforms (#517)

git-subtree-dir: apollo-ios
git-subtree-split: 7918704815048da9e9953ebf61ad8b292687a16d
BobaFetters pushed a commit that referenced this pull request Oct 24, 2024
…non-iOS platforms

git-subtree-dir: apollo-ios
git-subtree-mainline: b42c149
git-subtree-split: 7918704815048da9e9953ebf61ad8b292687a16d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants