-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Bug with AnyHashable coercion for non-iOS platforms #517
Conversation
@VMLe: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-ios-docc pending review.Visit the deploys page to approve it
|
👷 Deploy request for eclectic-pie-88a2ba pending review.Visit the deploys page to approve it
|
✅ Docs Preview ReadyNo new or changed pages found. |
Thank you for this! I'm happy to accept this PR. Just want to make sure we have the correct versions for each platform. Where did you get the versions that you added to the check for each platform from? This behavior of AnyHashable isn't well documented, and I want to make sure we are getting it right. |
I can confirm that for macOS, AnyHashable coercion starts working correctly with macOS 11.3, based on the data we get from Sentry and our observations. Also, all the versions I mentioned, including iOS 14.5, are related to Xcode 12.5 and have similar release dates and release notes. ( macOS, iOS, watchOS, tvOS ) However, you are correct — Apple does not provide any information about this issue. Consequently, I do not have confirmation for tvOS and watchOS due to the lack of available data. I believe that all these versions are closely related. However, if you feel that the connection between these versions is insufficient, I can remove watchOS and tvOS from this pull request. |
79187048 fix: Bug with AnyHashable coercion for non-iOS platforms (#517) git-subtree-dir: apollo-ios git-subtree-split: 7918704815048da9e9953ebf61ad8b292687a16d
…non-iOS platforms git-subtree-dir: apollo-ios git-subtree-mainline: b42c149 git-subtree-split: 7918704815048da9e9953ebf61ad8b292687a16d
We encountered a similar issue on the macOS 11..<11.3 versions, which has been fixed for iOS.
Although the issue was observed on macOS, I suggest including all platforms that could potentially face the same problem.
This PR extends the
_AnyHashableCanBeCoerced
check to include macOS, watchOS, and tvOS with their respective minimum versions.