fix: Assign websocket callback queue before connecting #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs Preview ReadyNo new or changed pages found. |
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
AnthonyMDev
approved these changes
Oct 31, 2024
|
This seems really difficult to test, so I don't think we need to add a test. But it might be a good idea to add a comment to ensure that nobody moves that code again. |
AnthonyMDev
approved these changes
Oct 31, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Oct 31, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Oct 31, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Oct 31, 2024
0adf0250 fix: Assign websocket callback queue before connecting (#529) git-subtree-dir: apollo-ios git-subtree-split: 0adf0250e7f363345117766f3689e4c3e669c910
BobaFetters
pushed a commit
that referenced
this pull request
Oct 31, 2024
…fore connecting git-subtree-dir: apollo-ios git-subtree-mainline: 2ee7d7e git-subtree-split: 0adf0250e7f363345117766f3689e4c3e669c910
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes apollographql/apollo-ios#3466.
Assign the callback queue before connecting to prevent potential data race.