Initial file upload concept #116

wpK · 2017-07-27T17:54:47Z

As discussed in #114, this is an example of file upload support without forcing to a specific server spec.

I made this PR to get the conversation going. The naming, progress handling, GraphQLFile input error handling all need to be improved on.

An example of use:

let imageData: Data = ...
let imageFileURL: URL = ...
let pdfInputStream: InputStream = ...
let pdfContentLength: UInt64 = ...

var files: [GraphQLFile] = []
files.append(GraphQLFile(fieldName: "files.0", originalName: "test-file-1.png", mimeType: "image/png", data: imageData))
files.append(GraphQLFile(fieldName: "files.1", originalName: "test-file-2.png", mimeType: "image/png", fileURL: imageData))
files.append(GraphQLFile(fieldName: "files.2", originalName: "test-file-3.pdf", mimeType: "application/pdf", inputStream: pdfData, contentLength: pdfContentLength))

let mutation = MultipleUploadMutation(files: files.map({Upload(fieldName: $0.fieldName, name: $0.originalName, type: $0.mimeType, size: $0.count)}))

let progressHandler = { progress in
  print("Upload progress: \(progress)")
}

let client = ApolloClient( ... )

// progressHandler is optional
client.performUpload(mutation: mutation, files: files, progressHandler: progressHandler) { (result, error) in
  ...
}

apollo-cla · 2017-07-27T17:54:48Z

@wpK: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

martijnwalraven · 2017-07-27T18:38:42Z

@wpK: Thanks a lot, happy to see this get in! I'll try to take a closer look tomorrow or else over the weekend.

martijnwalraven · 2017-08-17T00:44:48Z

Hey, I'm sorry I haven't gotten to this yet. I'll be on vacation for the next week and a half, but I'll take a look after.

wpK · 2017-08-22T17:05:28Z

@martijnwalraven No problem. Enjoy your vacation!

FellnerDotDev · 2017-10-24T15:06:26Z

@martijnwalraven I hope you have had a pleasant vacation. Is there any chance that the merge conflicts get resolved in the near future?

martijnwalraven · 2017-10-24T15:26:52Z

@TheFellner I'm caught up in preparing for GraphQL Summit right now, but let's get back to this next week. I don't think this is ready to be merged, but it's a good starting point for discussing API design.

gorbat-o · 2018-05-25T13:22:23Z

Hey,

Is it still something you are working on ?

Thanks :)

dphov · 2018-06-29T12:16:04Z

Please, someone, resolve this PR
@wpK

vinayan3 · 2018-07-03T20:58:54Z

Is there anything we can do to help get this PR through? It'll be super useful to have it working in the client.

LeeWong · 2018-07-03T21:05:20Z

Please merge this PR. Thanks.

highthem · 2018-11-23T15:55:53Z

any news about this? is it released?
@wpK
@martijnwalraven

marinofelipe · 2018-12-04T20:05:58Z

This would be a great addition for us. Is there any news about it? Can we help somehow?

psi-gh · 2019-01-14T15:00:17Z

Waiting for this.

tylergets · 2019-01-20T22:38:30Z

Would also support this pull request, file uploads are mainstreamed in apollo-server now

otri · 2019-02-06T06:17:48Z

I'm hoping to get this working on my fork here:
https://github.com/otri/apollo-ios

It's still a work in progress today, but I hope to have it running very soon. I've resolved all the merge conflicts with master.

otri · 2019-02-06T08:41:19Z

Okay I've learned that there's a lot more to the schema codegen. Would need Apollo to figure this one out. My fork corrects for a conflict with Progress, but I couldn't actually get the implementation for the mutation hooked up.

the-scott-davis · 2019-02-21T20:21:00Z

This is so needed.... seems like a major oversight to not support this. @otri I took at look at your PR, looks solid, but as you said, need support from the Apollo team for the codegen part it appears.

kimdv · 2019-06-11T13:31:19Z

Hi @wpK and @martijnwalraven

Do you need any help here?
I'm looking for this feature, so if you need help feel free to reach out! 🚀

otri · 2019-06-11T14:08:22Z

I've learned that using graphql for file transport is not a good idea. Turns out it's best to push your files using a regular REST API, and let the meta data reflect the availability of the files. This keeps the channel for graphql changes fast and light, and the REST API can be built to be scalable for larger bulk transport in the future.

On Tue, Jun 11, 2019 at 22:31 Kim de Vos ***@***.***> wrote: Hi @wpK <https://github.com/wpK> and @martijnwalraven <https://github.com/martijnwalraven> Do you need any help here? I'm looking for this feature, so if you need help feel free to reach out! 🚀 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#116?email_source=notifications&email_token=AAHHYAVDJM4BPGJE753L3QDPZ6SKZA5CNFSM4DUWQMW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXND47A#issuecomment-500842108>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHHYAWHE757CVKII4HKXQ3PZ6SKZANCNFSM4DUWQMWQ> .

--

…

_______________________ Aaron Hilton Steampunk Digital mobile: +81 80 3947 6874 <+818039476874> skype: otristudios facetime: aaron@steampunk.digital Monocle 3D Portrait <https://goo.gl/w0JV66>

designatednerd · 2019-07-10T19:27:31Z

@wpK Are you interested in continuing this PR? If not I can close it out for you and take a stab myself.

otri · 2019-07-10T21:58:29Z

Nope, go for it.

On Thu, Jul 11, 2019 at 04:27 Ellen Shapiro ***@***.***> wrote: @wpK <https://github.com/wpK> Are you interested in continuing this PR? If not I can close it out for you and take a stab myself. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#116?email_source=notifications&email_token=AAHHYAVMO5Y3FCNDH7EZGODP6YZ2PA5CNFSM4DUWQMW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZUPQ2A#issuecomment-510195816>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHHYAWGCPQM7YFQ6JPR46LP6YZ2PANCNFSM4DUWQMWQ> .

--

…

_______________________ Aaron Hilton Steampunk Digital mobile: +81 80 3947 6874 <+818039476874> skype: otristudios facetime: aaron@steampunk.digital Monocle 3D Portrait <https://goo.gl/w0JV66>

designatednerd · 2019-07-11T11:03:43Z

Thanks @otri - I'd like to get that confirmation from the original author, @wpK, before I close this (or if I don't hear from him in a couple weeks, I'll close it anyway).

kimdv · 2019-07-11T11:20:43Z

@designatednerd I have a branch fork with the 0.10.1 working with file upload.
https://github.com/trifork/apollo-ios

I can rebase to 0.11.0 and open an PR?

designatednerd · 2019-07-11T11:29:28Z

@kimdv absolutely!

designatednerd · 2019-07-15T14:00:43Z

Closing this in favor of #626 since that one's been rebased

wpK · 2019-07-15T18:00:18Z

@designatednerd I haven't touched this in awhile. Last time I checked the Apollo server was adding official file upload support and I never got around to updating to the new spec. I'll watch #626 and when I have some more time try to contribute where I can.

designatednerd · 2019-07-16T13:24:49Z

@wpK Thank you - Yeah #626 is ready for a look if you've got questions!

File upload concept - Taken from #116

Co-authored-by: Zach FettersMoore <zach.fetters@apollographql.com> Co-authored-by: Maria Elisabeth Schreiber <maria.schreiber@apollographql.com> Co-authored-by: gh-action-runner <runner@Mac-1698338401160.local> Co-authored-by: Anthony Miller <anthonymdev@gmail.com> Co-authored-by: gh-action-runner <runner@Mac-1698344533451.local> Co-authored-by: Hesham Salman <iron-ham@github.com> Co-authored-by: Syed Zohair Abbas Hadi <45510142+zohairhadi@users.noreply.github.com> Co-authored-by: gh-action-runner <runner@Mac-1698701484703.local>

wpK added 4 commits September 26, 2017 19:37

Initial implementation for file upload support

de4a2ce

Support for progress updates

6f6f31b

SessionDelegate is now properly called

3554952

Progress is now working properly

c0a001c

wpK force-pushed the master branch from 3016410 to c0a001c Compare September 26, 2017 23:44

kimdv mentioned this pull request Jul 11, 2019

File upload concept - Taken from #116 #626

Merged

designatednerd closed this Jul 15, 2019

designatednerd added a commit that referenced this pull request Jul 18, 2019

Merge pull request #626 from kimdv/kimdv/graphql-file-upload

1ff23e3

File upload concept - Taken from #116

ttrznadel mentioned this pull request Jun 24, 2020

"Optional is only JSONEncodable if Wrapped is" fatal error occurs on Optional #1271

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial file upload concept #116

Initial file upload concept #116

wpK commented Jul 27, 2017

apollo-cla commented Jul 27, 2017

martijnwalraven commented Jul 27, 2017

martijnwalraven commented Aug 17, 2017

wpK commented Aug 22, 2017

FellnerDotDev commented Oct 24, 2017

martijnwalraven commented Oct 24, 2017

gorbat-o commented May 25, 2018

dphov commented Jun 29, 2018 •

edited

Loading

vinayan3 commented Jul 3, 2018

LeeWong commented Jul 3, 2018

highthem commented Nov 23, 2018 •

edited

Loading

marinofelipe commented Dec 4, 2018

psi-gh commented Jan 14, 2019

tylergets commented Jan 20, 2019

otri commented Feb 6, 2019

otri commented Feb 6, 2019

the-scott-davis commented Feb 21, 2019

kimdv commented Jun 11, 2019

otri commented Jun 11, 2019 via email

designatednerd commented Jul 10, 2019

otri commented Jul 10, 2019 via email

designatednerd commented Jul 11, 2019

kimdv commented Jul 11, 2019

designatednerd commented Jul 11, 2019

designatednerd commented Jul 15, 2019

wpK commented Jul 15, 2019

designatednerd commented Jul 16, 2019

Initial file upload concept #116

Initial file upload concept #116

Conversation

wpK commented Jul 27, 2017

apollo-cla commented Jul 27, 2017

martijnwalraven commented Jul 27, 2017

martijnwalraven commented Aug 17, 2017

wpK commented Aug 22, 2017

FellnerDotDev commented Oct 24, 2017

martijnwalraven commented Oct 24, 2017

gorbat-o commented May 25, 2018

dphov commented Jun 29, 2018 • edited Loading

vinayan3 commented Jul 3, 2018

LeeWong commented Jul 3, 2018

highthem commented Nov 23, 2018 • edited Loading

marinofelipe commented Dec 4, 2018

psi-gh commented Jan 14, 2019

tylergets commented Jan 20, 2019

otri commented Feb 6, 2019

otri commented Feb 6, 2019

the-scott-davis commented Feb 21, 2019

kimdv commented Jun 11, 2019

otri commented Jun 11, 2019 via email

designatednerd commented Jul 10, 2019

otri commented Jul 10, 2019 via email

designatednerd commented Jul 11, 2019

kimdv commented Jul 11, 2019

designatednerd commented Jul 11, 2019

designatednerd commented Jul 15, 2019

wpK commented Jul 15, 2019

designatednerd commented Jul 16, 2019

dphov commented Jun 29, 2018 •

edited

Loading

highthem commented Nov 23, 2018 •

edited

Loading