fix: apollo-ios-cli code generation on CocoaPods installation #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docs canceled.
|
AnthonyMDev
approved these changes
Oct 5, 2022
This was referenced Oct 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2543
This moves the frontend JS bundle from it's own file into a Swift
String; it was already inefficient to be reading from a file only to init aString, now we can cut down on the processing needed to load the JS code and fix the bug. The root issue is that the.jsfile was a bundle resource of the ApolloCodegenLib module and that was being deleted after the pod installation = error when it was being loaded bygeneratecommand.