Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiline deprecation and enum warnings #2579

Merged
merged 5 commits into from
Oct 12, 2022

Conversation

AnthonyMDev
Copy link
Contributor

@AnthonyMDev AnthonyMDev commented Oct 12, 2022

This combines the implementation for #2544 and #2547 with a few minor improvements.

@netlify
Copy link

netlify bot commented Oct 12, 2022

👷 Deploy Preview for apollo-ios-docs processing.

Name Link
🔨 Latest commit 7ec00e0
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docs/deploys/63471c7a85a5ba0009b03831

@netlify
Copy link

netlify bot commented Oct 12, 2022

Deploy Preview for apollo-ios-docs canceled.

Name Link
🔨 Latest commit 1ef6e64
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docs/deploys/634724ba9ea00300097a0d90

@AnthonyMDev AnthonyMDev marked this pull request as draft October 12, 2022 19:59
@AnthonyMDev AnthonyMDev force-pushed the tiziano/fix-multiline-deprecation branch from fe9d835 to 1ef6e64 Compare October 12, 2022 20:34
@AnthonyMDev AnthonyMDev marked this pull request as ready for review October 12, 2022 20:41
@calvincestari
Copy link
Member

Merging since the test failure is a known transient and we're dealing with that elsewhere - URLDownloaderTests.testDownloader_withCorrectResponse_shouldNotThrow.

@calvincestari calvincestari merged commit 7fdf31c into main Oct 12, 2022
@calvincestari calvincestari deleted the tiziano/fix-multiline-deprecation branch October 12, 2022 21:20
@calvincestari calvincestari mentioned this pull request Oct 12, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants