Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Uses correct casing for schema name in generated namespace #2586

Merged
merged 9 commits into from
Oct 15, 2022
Merged

fix: Uses correct casing for schema name in generated namespace #2586

merged 9 commits into from
Oct 15, 2022

Conversation

calvincestari
Copy link
Member

PR 1 of 3 for #2546

This PR:

  • Correctly cases schemaName when used in namespacing
  • Refactored logic to use the config schema name and not the IR schema name
  • Removes schema name from function declarations when config is already present

@netlify
Copy link

netlify bot commented Oct 14, 2022 •
edited
Loading

✅ Deploy Preview for apollo-ios-docs canceled.

Name Link
🔨 Latest commit 47b0dfc
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docs/deploys/6349b96c8284d70008606ca4

@AnthonyMDev
Copy link
Contributor

Thanks so much for this! Approved!

@AnthonyMDev
Copy link
Contributor

And nice job cleaning up the unneeded moduleName parameters

@calvincestari calvincestari merged commit 14888b4 into main Oct 15, 2022
@calvincestari calvincestari deleted the fix/schema-name branch October 15, 2022 02:19
This was referenced Oct 21, 2022
Merged
Closed
@calvincestari calvincestari linked an issue Oct 24, 2022 that may be closed by this pull request
Problem with schemaName #2546
Closed
@calvincestari calvincestari mentioned this pull request Dec 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyMDev AnthonyMDev AnthonyMDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with schemaName
2 participants
@calvincestari @AnthonyMDev