-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: Drop plugins for SwiftPM #2649
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docs canceled.
|
AnthonyMDev
force-pushed
the
fix/drop-spm-plugins
branch
from
November 15, 2022 20:00
89f8b00
to
de286e0
Compare
AnthonyMDev
force-pushed
the
fix/drop-spm-plugins
branch
from
November 15, 2022 22:19
de286e0
to
7e71aae
Compare
AnthonyMDev
approved these changes
Nov 15, 2022
calvincestari
commented
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't approve this PR because I created it, 'Comment' is the only option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2565
This removes the three plugins from our package definition, preventing the CLI being used as a plugin in both
swift package
commands as well as from within Xcode.We regret making this change but the current workflow within SwiftPM and Xcode is not suitable to the experience we want to deliver. Once those plugin environments mature a bit more we can bring back the plugins, they do make version alignment easier.