fix: Add validation check for conflicting configuration values #2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docs canceled.
|
AnthonyMDev
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2663
This PR adds a validation step to check that the configured output module type does not conflict with the
cocoapodsCompatibleImportStatementsvalue. Incorrect combinations of these two properties can result in invalidimportstatements in the generated code. An error is now thrown informing the user of the conflict and how it can be resolved.Error: The codegen configuration has conflicting values: cocoapodsCompatibleImportStatements cannot be set to 'true' when the output schema types module type is Swift Package Manager. Change the cocoapodsCompatibleImportStatements value to 'false', or choose a different module type, to resolve the conflict.