fix: GraphQLEnum value camelCase conversion strategy #2745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docs canceled.
|
|
I'm putting this back into draft to fix #2749. |
AnthonyMDev
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Thanks so much for nailing this @calvincestari! Let's just make sure the license is okay and then move this forward!
Sources/ApolloCodegenLib/Templates/RenderingHelpers/GraphQLEnumValue+Rendered.swift
Outdated
Show resolved
Hide resolved
calvincestari
commented
Jan 5, 2023
| } | ||
| return value | ||
|
|
||
| return value.components(separatedBy: "_") |
There was a problem hiding this comment.
It might look odd to be separating by _ and then converting empty elements back to _ but that's the trick to preserving leading/trailing _ without having to find the first/last indexes around them.
There was a problem hiding this comment.
components(separatedBy:) also preserves empty _ positions vs. split which would just give us the inner 'words'.
AnthonyMDev
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
.camelCaseconversation strategy implementationUses the_convertFromSnakeCaseimplementation fromJSONDecoderinFoundationwith modifications. This question in the Swift forums makes me hopeful that one day we can remove this code and use a Swift standard library implementation, but we're not there yet.