Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Conditional logic using GraphQLNullable variables #2794

Merged
merged 3 commits into from
Jan 25, 2023
Merged

fix: Conditional logic using GraphQLNullable variables #2794

merged 3 commits into from
Jan 25, 2023

Conversation

calvincestari
Copy link
Member

Fixes #2690

  • Adds logic to evaluate GraphQLNullable conditional variables
  • Adds skip/include tests using GraphQLNullable variables
  • Removes commented out integration conditional tests

@netlify
Copy link

netlify bot commented Jan 25, 2023 •
edited
Loading

✅ Deploy Preview for apollo-ios-docs canceled.

Name Link
🔨 Latest commit 2d2d908
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docs/deploys/63d0d6b11e3b5e00083106f7

@calvincestari calvincestari marked this pull request as ready for review January 25, 2023 22:29
@calvincestari calvincestari merged commit ab4a936 into main Jan 25, 2023
@calvincestari calvincestari deleted the fix/include-directive-default-value branch January 25, 2023 22:35
@AnthonyMDev AnthonyMDev mentioned this pull request Jan 30, 2023
Closed
@calvincestari calvincestari mentioned this pull request Feb 8, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyMDev AnthonyMDev AnthonyMDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@include directive based on variable with default value drops the included data
2 participants
@calvincestari @AnthonyMDev