TDA-3417 crash in socket #3465
Closed
TDA-3417 crash in socket #3465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connAck messages from AppSync come with a timeout in milliseconds for the client to kill the connection when it stays too long without receiving any messages, including keep-alive requests.
fix: reconnect to websocket on timeout
Upgrade to 0.53.0
update to 1.9.3
Updates Apollo to 1.9.3
TDA-3865: Update to Support Xcode 16
|
@ValeriiIamkovyi: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-ios-docs pending review.Visit the deploys page to approve it
|
✅ Docs Preview ReadyNo new or changed pages found. |
|
We do not accept PRs directly to the 'apollo-ios' repo. All development is done through the 'apollo-ios-dev' repo, please see the CONTRIBUTING guide for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've made several improvements to prevent crashes in this method:
Instead of converting
DatatoNSDataand back, we now work directly withData. The conversion was unnecessary and could introduce memory management issues. TheDataappend method is used for better efficiency and safety.Replaced
UnsafeRawPointerwithwithUnsafeBytesto safely access the raw pointer, avoiding potential memory issues.Code review check list
Ticket
TDA-3417