Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for scripts being included in app bundle when using cocoapods #575

Merged

Conversation

cltnschlosser
Copy link
Contributor

Using the resources field causes the scripts to be included in the app bundle. Instead preserve_paths makes sure the files aren't deleted by cocoapods, but doesn't include them in the app bundle. https://guides.cocoapods.org/syntax/podspec.html#preserve_paths

Copy link
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@designatednerd designatednerd merged commit b5fb0a9 into apollographql:master Jun 25, 2019
@cltnschlosser cltnschlosser deleted the cocoapods-scripts branch June 29, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants