Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header configuration + Fix GET with null parameter #602

Merged
merged 11 commits into from
Jul 3, 2019
Merged

Header configuration + Fix GET with null parameter #602

merged 11 commits into from
Jul 3, 2019

Commits on Jul 3, 2019

  1. Fix 4 vs 2 space alignment issues

    @designatednerd
    designatednerd committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    4499a78 View commit details
    Browse the repository at this point in the history

  2. Add ability to bail out of or update the parameters of a request with… 

    … an optional delegate.
    @designatednerd
    designatednerd committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    ee39b0d View commit details
    Browse the repository at this point in the history

  3. break out logic to transform GET requests into a transformer for test… 

    …ing, clarity, and null param handling
    @designatednerd
    designatednerd committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    4d160da View commit details
    Browse the repository at this point in the history

  4. pull out request construction into its own method for clarity

    @designatednerd
    designatednerd committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    a39cd0b View commit details
    Browse the repository at this point in the history

  5. Add request completion delegate, rename pre-flight delegate

    @designatednerd
    designatednerd committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    bc85bb6 View commit details
    Browse the repository at this point in the history

  6. add and test retry mechanism

    @designatednerd
    designatednerd committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    65b9cd6 View commit details
    Browse the repository at this point in the history

  7. better wording on error description

    @designatednerd
    designatednerd committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    d66e400 View commit details
    Browse the repository at this point in the history

  8. fix typo in parameter name 🤦‍♀️ 

    If I spell received correctly on the first try it's a clear sign i'm having an aneurysm
    @designatednerd
    designatednerd committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    16c70bd View commit details
    Browse the repository at this point in the history

  9. rename parameter for consistency with platform naming

    @designatednerd
    designatednerd committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    d24b233 View commit details
    Browse the repository at this point in the history

  10. rename cancellation error

    @designatednerd
    designatednerd committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    f983efc View commit details
    Browse the repository at this point in the history

  11. create base delegate protocol so the user only has to pass in one par… 

    …ameter if their delegate conforms to multiple sub-protocols.
    @designatednerd
    designatednerd committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    89cfced View commit details
    Browse the repository at this point in the history