-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation to show how to use new delegates and cache policy #618
Conversation
|
||
```swift | ||
let apollo = ApolloClient(url: URL(string: "http://localhost:8080/graphql")!) | ||
class Apollo { | ||
static let shared = Apollo() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a singleton class really needed? What is the benefit over a global variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, too fast, I see the example below with the delegate implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that plus I'm very much team "If you're gonna use a singleton, use a singleton. Don't use the App Delegate as a pseudo-singleton as that's not what it's for."
…p Delegate for the basic setup
…kTransportDelegate` and other advanced usages.
4f7d52f
to
40b7724
Compare
Also removed old link to CocoaDocs (which is dead) and fixed some stray whitespace in the iOS build script. |
In this PR:
HTTPTransportClientDelegate
that came out with v0.11.0fetching-queries.md
to include information about usingGET
for queries and add the most recent cache policy addition.