Move Code Generation From Bash to Swift Scripts #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
designatednerd
force-pushed
the
swift-codegen
branch
2 times, most recently
from
38b397c
to
2b8b820
Compare
designatednerd
force-pushed
the
swift-codegen
branch
from
2b8b820
to
a1dca7c
Compare
designatednerd
force-pushed
the
swift-codegen
branch
2 times, most recently
from
5406eb2
to
0ede944
Compare
designatednerd
force-pushed
the
swift-codegen
branch
from
0ede944
to
d3e6ac4
Compare
designatednerd
force-pushed
the
swift-codegen
branch
4 times, most recently
from
9b571ff
to
5c09111
Compare
designatednerd
force-pushed
the
swift-codegen
branch
7 times, most recently
from
8552faa
to
7f2d3be
Compare
designatednerd
changed the title
|
OK folks, I would love some feedback on all this. Hit me with your best shots! 🥊 |
|
Hi! I only looked at the docs part, but they look cool. Quite some setup, but then I could see this being long-term nice for a team (next time I'm on one doing GraphQL). Good idea! |
|
Yes! A big piece of the idea here is to make it way more seamless for me to work piecemeal on some major code generation changes, which are all eventually going to live in the |
|
(thought of a WAY easier way to get the sourceroot) |
bleege
reviewed
Feb 18, 2020
| import Foundation | ||
|
|
||
| /// Bash command runner | ||
| public struct Basher { |
|
+100 to moving away from Bash. 🎉 |
…a download pages.
designatednerd
force-pushed
the
swift-codegen
branch
from
865e64a
to
af93d09
Compare
docs/source/api/ApolloCodegenLib/structs/ApolloCodegenOptions.md
Outdated
Show resolved
Hide resolved
Edits to Swift scripting article
|
It'll be a couple days before I ship this - I have some serious wrecking ball work to do with rearranging some code to get a couple things to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is explained in detail in #939, but at a basic level I'm sick of having so much untested bash code driving our code generation, so I'm moving a bunch of it to Swift.