Persist Record arguments/metadata with the SQL Json backend #4211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
BoD
force-pushed
the
metadata-on-records-json
branch
from
66415a6
to
c7f0c68
Compare
...nMain/kotlin/com/apollographql/apollo3/cache/normalized/api/internal/JsonRecordSerializer.kt
Outdated
Show resolved
Hide resolved
...nMain/kotlin/com/apollographql/apollo3/cache/normalized/api/internal/JsonRecordSerializer.kt
Outdated
Show resolved
Hide resolved
|
✅ |
apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/CompiledGraphQL.kt
Outdated
Show resolved
Hide resolved
apollo-compiler/src/main/kotlin/com/apollographql/apollo3/compiler/codegen/fieldPolicyArgs.kt
Outdated
Show resolved
Hide resolved
apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/CompiledGraphQL.kt
Show resolved
Hide resolved
| recordMerger = CursorPaginationRecordMerger() | ||
| ) | ||
| .serverUrl("unused") | ||
| .build() |
There was a problem hiding this comment.
Looks like you're not using any of the ApolloClient functionality here? If that's the case, you can instanciate an ApolloStore directly:
ApolloStore(
normalizedCacheFactory = normalizedCacheFactory,
cacheKeyGenerator = cacheKeyGenerator,
metadataGenerator = metadataGenerator,
apolloResolver = apolloResolver,
recordMerger = recordMerger
)
| val incomingList = incomingFieldValue as List<*> | ||
| val mergedList = mergeLists(existingList, incomingList, existingOffset, incomingOffset) | ||
| mergedFields[fieldKey] = mergedList | ||
| mergedMetadata[fieldKey] = mapOf("offset" to min(existingOffset, incomingOffset)) |
There was a problem hiding this comment.
Using min doesn't take into account the case where existing and incoming do not join (the early returns in mergeLists)
.../src/commonMain/kotlin/com/apollographql/apollo3/cache/normalized/api/internal/Normalizer.kt
Show resolved
Hide resolved
| UsersCursorBasedQuery.Edge("xx44", UsersCursorBasedQuery.Node("44", "Peter", "peter@a.com", "User")), | ||
| UsersCursorBasedQuery.Edge("xx45", UsersCursorBasedQuery.Node("45", "Alice", "alice@a.com", "User")), | ||
| UsersCursorBasedQuery.Edge("xx46", UsersCursorBasedQuery.Node("46", "Bob", "bob@a.com", "User")), | ||
| UsersCursorBasedQuery.Edge("xx47", UsersCursorBasedQuery.Node("47", "Charlie", "charlie@a.com", "User")), |
There was a problem hiding this comment.
Could you 🐶 🥫 test builders here?
…aphql/apollo3/cache/normalized/api/internal/JsonRecordSerializer.kt Co-authored-by: Martin Bonnin <martin@mbonnin.net>
…s to keep in pagination field names
…/CompiledGraphQL.kt Co-authored-by: Martin Bonnin <martin@mbonnin.net>
Co-authored-by: Martin Bonnin <martin@mbonnin.net>
Co-authored-by: Martin Bonnin <martin@mbonnin.net>
BoD
force-pushed
the
metadata-on-records-json
branch
from
fa2fde3
to
6b18de4
Compare
...nMain/kotlin/com/apollographql/apollo3/cache/normalized/api/internal/JsonRecordSerializer.kt
Show resolved
Hide resolved
martinbonnin
approved these changes
Jun 27, 2022
* Introduce FieldRecordMerger * Fix badly named FieldMerger
martinbonnin
added a commit
that referenced
this pull request
Jun 29, 2022
Co-authored-by: Martin Bonnin <martin@mbonnin.net>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add a test/sample for offset based pagination.