Fix: Remove incorrect cors option type from apollo-server-express's c…

…onstructor #2330 (comment)
apollographql · Feb 25, 2019 · b2bfd08 · b2bfd08
1 parent 85470d0
commit b2bfd08
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/apollo-server-express/src/ApolloServer.ts b/packages/apollo-server-express/src/ApolloServer.ts
@@ -76,7 +76,6 @@ export interface ExpressContext {
 }
 
 export interface ApolloServerExpressConfig extends Config {
-  cors?: CorsOptions | boolean;
   context?: ContextFunction<ExpressContext, Context> | Context;
 }
 

diff --git a/packages/apollo-server/src/index.ts b/packages/apollo-server/src/index.ts
@@ -26,7 +26,11 @@ export class ApolloServer extends ApolloServerBase {
   private httpServer?: http.Server;
   private cors?: CorsOptions | boolean;
 
-  constructor(config: ApolloServerExpressConfig) {
+  constructor(
+    config: ApolloServerExpressConfig & {
+      cors?: CorsOptions | boolean;
+    },
+  ) {
     super(config);
     this.cors = config && config.cors;
   }