apollo-server-core: fix plugins that depend on this (#2470)

apollographql · Mar 19, 2019 · dcd572f · dcd572f
1 parent b2f5b18
commit dcd572f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ### vNEXT
 
+- Allow `GraphQLRequestListener` callbacks in plugins to depend on `this`. [PR #2470](https://github.com/apollographql/apollo-server/pull/2470)
+
 ### v2.4.8
 
 - No functional changes in this version.  The patch version has been bumped to fix the `README.md` displayed on the [npm package for `apollo-server`](https://npm.im/apollo-server) as a result of a broken publish.  Apologies for the additional noise!

diff --git a/packages/apollo-server-core/src/utils/dispatcher.ts b/packages/apollo-server-core/src/utils/dispatcher.ts
@@ -21,7 +21,7 @@ export class Dispatcher<T> {
       this.targets.map(target => {
         const method = target[methodName];
         if (method && typeof method === 'function') {
-          return method(...args);
+          return method.apply(target, args);
         }
       }),
     );
@@ -42,7 +42,7 @@ export class Dispatcher<T> {
     for (const target of this.targets) {
       const method = target[methodName];
       if (method && typeof method === 'function') {
-        const didEndHook = method(...args);
+        const didEndHook = method.apply(target, args);
         if (didEndHook) {
           didEndHooks.push(didEndHook);
         }