Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine throws error when serializing trace data for file uploads #1667

Closed
nmchaves opened this issue Sep 14, 2018 · 0 comments · Fixed by #1668
Closed

Engine throws error when serializing trace data for file uploads #1667

nmchaves opened this issue Sep 14, 2018 · 0 comments · Fixed by #1668

Comments

@nmchaves
Copy link
Contributor

nmchaves commented Sep 14, 2018

Using Apollo Server 2 file uploads with Apollo Engine will cause the server to throw an error and return a 500 response to the client. Furthermore, this event will not be logged to Apollo Engine.

More specifically, the following line will throw an error when it tries to stringify a file upload promise (using Apollo Server 2's file upload feature):
https://github.com/apollographql/apollo-server/blob/master/packages/apollo-engine-reporting/src/extension.ts#L141

The exception is:

TypeError: Converting circular structure to JSON

This probably means that the file upload promise contains a circular reference. JSON doesn't currently support circular references (see MDN docs)

This issue will be resolved by #1668

@ghost ghost added the ✋ blocking Prevents production or dev due to perf, bug, build error, etc.. label Sep 14, 2018
@abernix abernix removed the ✋ blocking Prevents production or dev due to perf, bug, build error, etc.. label Sep 3, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants