Catch Error if JSON.Stringify Fails for Engine Trace #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
✋ blocking
nmchaves
commented
Sep 14, 2018
| @@ -214,11 +214,11 @@ export class EngineReportingAgent<TContext = any> { | |||
| message.byteOffset, | |||
| message.byteLength, | |||
| ); | |||
| gzip(messageBuffer, (err, compressed) => { | |||
| gzip(messageBuffer, (err, gzipResult) => { | |||
There was a problem hiding this comment.
These changes were not related to this PR. They were tslint errors (no-shadowed-variable)
|
@nmchaves Thank you so much! We'll get it release straight away |
|
@evans My pleasure, thanks for the quick review! I'll be sure to test it out once it's released |
|
Update: @evans Thanks for getting this released so quickly 🚀! After upgrading to |
abernix
removed
the
✋ blocking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1667
When I make these changes locally, I see this in the Query Variables section of Engine's Inspector:
where
filewas the name of a mutation variable of typeUpload.Of course, for those variables that can be stringified, you'll still be able to see the actual value.