-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support deprecated directive on input fields #1881
Comments
@tomasaschan as soon as that comes into graphql-js, it will be supported here as well! |
Hello here... seems that it's now supported in graphqljs graphql/graphql-js#2855 si there a chance to bring this then ? |
@eMerzh What aspect of the system is currently not supporting deprecated input fields (when you are using the latest graphql-js)? It's definitely possible for me to believe that the entire Apollo platform doesn't consistently support this new feature but it's easier to answer if you tell me what you tried that didn't work. I'd expect that Apollo Server specifically should just support it out of the box once you upgrade graphql-js. |
The graphql-js fix was bundled in the 16.0.0 release here so until Apollo server can upgrade to v16 this won't get picked up. Upgrading graphql-js to 16 breaks with apollo-server at the moment (3.9.0 is latest) |
AS3 is supposed to work with graphql-js 16. Are you sure it doesn't? Could there be another dependency that you're using that doesn't support v16? |
There is an RFC and reference implementation for supporting
@deprecated
on input fields; see graphql/graphql-spec#525 and graphql/graphql-js#1560. It would be awesome if Apollo could support that too :)The text was updated successfully, but these errors were encountered: