Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deprecated directive on input fields #1881

Closed
1 task done
tomasaschan opened this issue Oct 25, 2018 · 5 comments
Closed
1 task done

Support deprecated directive on input fields #1881

tomasaschan opened this issue Oct 25, 2018 · 5 comments
Labels
⛲️ feature New addition or enhancement to existing solutions

Comments

@tomasaschan
Copy link

  • feature

There is an RFC and reference implementation for supporting @deprecated on input fields; see graphql/graphql-spec#525 and graphql/graphql-js#1560. It would be awesome if Apollo could support that too :)

@ghost ghost added the ⛲️ feature New addition or enhancement to existing solutions label Oct 25, 2018
@jbaxleyiii jbaxleyiii added the 🚧👷‍♀️👷‍♂️🚧 in triage Issue currently being triaged label Jul 8, 2019
@jbaxleyiii
Copy link
Contributor

@tomasaschan as soon as that comes into graphql-js, it will be supported here as well!

@abernix abernix removed 🚧👷‍♀️👷‍♂️🚧 in triage Issue currently being triaged labels Jul 9, 2019
@eMerzh
Copy link

eMerzh commented Oct 8, 2021

Hello here... seems that it's now supported in graphqljs graphql/graphql-js#2855

si there a chance to bring this then ?

@glasser
Copy link
Member

glasser commented Oct 8, 2021

@eMerzh What aspect of the system is currently not supporting deprecated input fields (when you are using the latest graphql-js)? It's definitely possible for me to believe that the entire Apollo platform doesn't consistently support this new feature but it's easier to answer if you tell me what you tried that didn't work. I'd expect that Apollo Server specifically should just support it out of the box once you upgrade graphql-js.

@apiel51
Copy link

apiel51 commented Jun 28, 2022

The graphql-js fix was bundled in the 16.0.0 release here so until Apollo server can upgrade to v16 this won't get picked up. Upgrading graphql-js to 16 breaks with apollo-server at the moment (3.9.0 is latest)

@glasser
Copy link
Member

glasser commented Jul 8, 2022

AS3 is supposed to work with graphql-js 16. Are you sure it doesn't? Could there be another dependency that you're using that doesn't support v16?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⛲️ feature New addition or enhancement to existing solutions
Projects
None yet
Development

No branches or pull requests

6 participants