Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated directive to arguments and input values #1560

Closed
wants to merge 9 commits into from

Conversation

smitt04
Copy link

@smitt04 smitt04 commented Oct 24, 2018

This is a WIP and is the start for supporting deprecated directive in arguments and input values.

This is in relation to RFC Proposal

@IvanGoncharov
Copy link
Member

This is a WIP and is the start for supporting deprecated directive in arguments and input values.

@smitt04 Great 🎉 Please, ping me when you will be ready for review.

@IvanGoncharov IvanGoncharov added the spec RFC Implementation of a proposed change to the GraphQL specification label Oct 25, 2018
@smitt04
Copy link
Author

smitt04 commented Oct 25, 2018

@IvanGoncharov I think I am ready to be reviewed. Let me know if there are more tests that need to be implemented.

@charliecorrigan
Copy link

I'm not familiar with the graphql repo library architecture. Once this feature is added into graphql-js, will it be available in express-graphql? Or will that require a new PR to duplicate the feature?

Copy link
Contributor

@mjmahone mjmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IvanGoncharov this looks good to me, but I think you have more context on how deprecation currently fits in the type definitions, so I think you're a better reviewer for this.

@smitt04 I will take another look at this in the next week if needed.

@modosc
Copy link

modosc commented Feb 11, 2020

i attempted the rebase/merge here - one spec is still failing though.

@smitt04
Copy link
Author

smitt04 commented Feb 11, 2020

I tried updating the pr

@modosc
Copy link

modosc commented Feb 26, 2020

@smitt04 i updated my branch, all specs pass. i don't think you can merge it in because i had already rebased off of master - should i open up a separate pr i opened #2464

Comment on lines 878 to 916
deprecationReason: arg.deprecationReason,
isDeprecated: arg.deprecationReason != null,
extensions: arg.extensions,
astNode: arg.astNode,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we make sure these arguments are always in the same order?

@@ -1547,6 +1563,7 @@ export type GraphQLInputFieldConfig = {|
description?: ?string,
type: GraphQLInputType,
defaultValue?: mixed,
deprecationReason?: ?string,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isDeprecated missing here?

@jturkel
Copy link

jturkel commented Jun 5, 2020

Should getIntrospectionQuery be updated to include deprecated input fields and arguments to be consistent with the current behavior of including deprecated fields and enum values?

@IvanGoncharov
Copy link
Member

Should getIntrospectionQuery be updated to include deprecated input fields and arguments to be consistent with the current behavior of including deprecated fields and enum values?

@jturkel Added in #2855 Thanks for pointing it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed spec RFC Implementation of a proposed change to the GraphQL specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants