Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missmatch with npmjs.com #369

Closed
ScallyGames opened this issue Apr 20, 2017 · 6 comments
Closed

Missmatch with npmjs.com #369

ScallyGames opened this issue Apr 20, 2017 · 6 comments

Comments

@ScallyGames
Copy link

The npm link on graphql.org leads to the graphql-server npm page which references github.com/apollostack/apollo-server as repository which den forwards to github.com/apollographql/graphql-server.

The npm page further uses a readme that seems to be deprecated, saying that one should run npm install apollo-server to install and use some code syntax if I'm not mistaken.

This problem only became apparent when npm complained because of a peer dependency missmatch, leading to #291 and #243 explaining that this was deprecated and npm install graphql-server-<variant> was the correct syntax as also noted in the readme of this repository.

All in all the conflicting and deprecated information is really confusing when starting using this lib so I think the information should be updated accordingly.

@helfer
Copy link
Contributor

helfer commented Apr 21, 2017

Thanks for bringing this to our attention, I'm fixing it right now.

@DxCx it also looks like the README.md files on npm for each package are extremely minimal and just link to the docs. I think we should change that.

@DxCx
Copy link
Contributor

DxCx commented Apr 21, 2017

@helfer
each package in packages can contain it's own README.md,
if you will remember when we spoke about splitting to variants you said that you will update the READMEs after we split..

@helfer
Copy link
Contributor

helfer commented Apr 21, 2017

Haha, I don't remember that, but it sounds like something I would say. Since I don't have a lot of time right now, I hope we can split up the work among a few people. Do you remember who the main authors are for the various packages?

@DxCx
Copy link
Contributor

DxCx commented Apr 21, 2017

nope, we can probably dig it from git log..
seems like:
koa - @HriBB
hapi - @nnance
express - @nnance
lambda has a readme as far as i remember..

@helfer
Copy link
Contributor

helfer commented Apr 22, 2017

ok, I think none of these people have made any commits recently. Let's just create an issue and tag it with "help wanted"!

@helfer
Copy link
Contributor

helfer commented Apr 22, 2017

#373.

@helfer helfer closed this as completed Apr 22, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants