Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor version bump for graphql-tools required for GraphQL 15 compatability #3954

Closed
zackdotcomputer opened this issue Apr 6, 2020 · 4 comments

Comments

@zackdotcomputer
Copy link

Ran into a low-urgency bug when I tried updating to graphql 15:

Currently:

Currently, most of the packages within this apollo-server monorepo have a dependency on graphql-tools pinned to ^4.0.0.

Problem:

Because of how npm handles transitive dependencies, machines with an earlier version of graphql-tools installed than the current 4.0.7 will not be updated to the latest version. That is, unless they manually add their own dev dependency, as this repo has in the root (package.json)[https://github.com/apollographql/apollo-server/blob/master/package.json].

This is a problem for future graphql: ^15.0.0 support, as graphql-tools 4.0.7 or higher will be required because it adds support for the new graphql package names.

Solution:

I suggest updating pinned versions in the package.json files to "graphql-tools": "^4.0.7". Then npm will update to that version.

@dandv
Copy link
Contributor

dandv commented Jun 4, 2020

I'd love it if graphql-tools were updated directly to v6 per the chore, so we can do only one major version compatibility test instead of two (v5, v6).

v6 also fixes this enum issue.

@wtrocki
Copy link

wtrocki commented Jun 4, 2020

I'd love it if graphql-tools were updated directly to v6 per the chore, so we can do only one major

It is very important to have Apollo server using latest graphql-tools. Lots of community members now updating the to latest GraphQL-tools that have significant improvements, but Apollo-Server internally still uses 0.4.0. This brings issues with typing - community packages that were creating custom directives using GraphQL-Tools might stop working after update etc.

Version 6.x GraphQL tools is fixing many different issues, so most of the project would not be able to avoid having two different versions. etc.

@glasser
Copy link
Member

glasser commented Feb 6, 2021

Going to handle this over at #4865.

@glasser
Copy link
Member

glasser commented Feb 11, 2021

OK, two parts to this:

@glasser glasser added this to the Release 2.21.0 milestone Feb 11, 2021
glasser added a commit that referenced this issue Feb 11, 2021
That's the version that's required for graphql@15 support. Let's make things
smoother by helping people get it installed even if they have an old
package-lock with 4.0.0 in it.

Fixes #3954.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants