Exported fetch declaration is slightly non-standard

[maxnachlinger]

Found in: apollo-server-env@master

Expected: The exported fetch function declaration adheres to the fetch standard.

Actual: It differs from the fetch standard via marking the initial argument as optional.

declare function fetch(
  input?: RequestInfo, // <--- this is what I'm on about
  init?: RequestInit,
): Promise<Response>;

Background:

IMHO the exported fetch function shouldn't allow the first argument to be omitted. The MDN fetch page shows this arg as required as does the living fetch standard - fetch args are really Request ctor args :)

Why am I bothering you about this?
I've created my own fun fetch function and want to pass it along to a RemoteGraphQLDataSource , since the first arg to my fetch function isn't optional, tsc is complaining.

[maxnachlinger]

Hey thanks for the fix!

[trevor-scheer]

Thanks for the report! The fix is released via commit c212627. You'll see the latest versions for whichever packages interest you listed in the commit message.