AS2: Move default options into listen function and add bodyParserConfig #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…od to configure bodyParser
evans
force-pushed
the
server-2.0/default-impl-params
branch
from
70ef7b3
to
685f85e
Compare
|
woot! excited for |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the options for the default apollo-server from the constructor into the listen function. The goals is to keep the server constructor the same across all environments. Additional functionality is added in other function, such as
listenorregisterServer.Additionally, @thepwagner found a bug, where
registerServerwas not called whendisableHealthCheckwas true on this line and requested the ability to configure the body parser of express.