Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo-server: remove extra configuration of registerServer from listen #1090

Merged
merged 1 commit into from
May 24, 2018

Conversation

evans
Copy link
Contributor

@evans evans commented May 24, 2018

This removes the healthcheck, body parser, and cors from the listen configurations in the default apollo-server. Since the listen interface is shared across all standalone node integrations, it was quite important to make the listen interface cleaner. The defaults are generous, with cors set to * and body parser limit to 50mb to allow large file uploads.

@evans evans added this to the Release 2.0 milestone May 24, 2018
@evans evans merged commit 5d109e9 into refactor-2.0 May 24, 2018
@evans evans deleted the server-2.0/simplify-default-listen branch May 24, 2018 04:52
@evans evans mentioned this pull request Jun 1, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant