-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Redis and Memcached #1191
Conversation
- apollo-server-caching (exports interface for KeyValueCache) - apollo-server-caching-memcached - apollo-server-caching-redis One issue now is that there is duplication of mocks and test code in each of the packages. It would be better if we had centralized integration tests for all cache connectors, community contributed or otherwise.
I think we can shorten the names down to |
"dependencies": { | ||
"apollo-server-env": "^2.0.0-rc.0", | ||
"apollo-server-caching": "^2.0.0-rc.0", | ||
"memcached": "^2.2.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing the types for these packages will provide a lot more confidence that we are doing the right thing.
npm install -D @types/memcached
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/redis/index.d.ts
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/memcached/index.d.ts
a4dadf3
to
7e6d282
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Let's squash it and include it in the next release 🎉
Great work @clarencenpy
Refactored caching connectors for Redis/Memcached into their own packages.
One issue now is that there is duplication of mocks and test code in each of the packages. It would be better if we had centralized integration tests for all cache connectors, community contributed or otherwise.