Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graphql dependency to server integrations #1232

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

olistic
Copy link
Contributor

@olistic olistic commented Jun 22, 2018

Fixes #1225

@olistic olistic force-pushed the peer-dependencies branch from 1c11cb9 to 6379c33 Compare June 22, 2018 19:43
@evans
Copy link
Contributor

evans commented Jun 22, 2018

@olistic Thank you so much for the PR! It would be better if graphql is a peer dependency of the integrations, so that a single version of graphql can be installed for the full package. Something like this line would be incredible

@olistic olistic force-pushed the peer-dependencies branch from 6379c33 to b50d9e5 Compare June 22, 2018 22:20
@olistic
Copy link
Contributor Author

olistic commented Jun 22, 2018

@evans Ups! I misunderstood your comment. What about apollo-server-integration-testsuite? Do we want the peer dependency there as well?

@evans evans added this to the Release 2.0 milestone Jun 22, 2018
@evans
Copy link
Contributor

evans commented Jun 22, 2018

@olistic The integration testsuite is a private package to the repository, so it doesn't need the peerDeps. Thank you so much for the PR!

@evans evans merged commit 76da232 into apollographql:version-2 Jun 22, 2018
@olistic olistic deleted the peer-dependencies branch June 22, 2018 22:55
@abernix
Copy link
Member

abernix commented Jun 26, 2018

The graphql@14 package is still a release-candidate (also, on npm) and utilizes semver "pre-release" versioning. This means the version range defined here only meets a version of graphql that hasn't been released yet. While that may seem like a forward-thinking idea, I'd caution against doing this until compatibility has been verified since offering it as a "peer dependency" today seems like an endorsement for its use.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants