Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies and exports #1257

Merged
merged 3 commits into from
Jun 27, 2018
Merged

Conversation

olistic
Copy link
Contributor

@olistic olistic commented Jun 27, 2018

This fixes #1251 by adding the graphql-tools and graphql-subscriptions dependencies to integrations to allow export * from 'graphql-tools' and export * from 'graphql-subscriptions' from them.

NOTE: graphql-subscriptions was only added to and exported from those integrations that support subscriptions.

Also, we are not exporting everything from graphql-tools and graphql-subscriptions from the apollo-server-core package anymore (no consumer of it was using any of those exports). If there's any objection with this, I can revert that commit.

@evans evans merged commit 8ef1818 into apollographql:version-2 Jun 27, 2018
@evans
Copy link
Contributor

evans commented Jun 27, 2018

@olistic Thank you so much!

@olistic olistic deleted the fix-dependencies branch June 27, 2018 19:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants