Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use apollo-upload-server 6.0.0-alpha.1 #1543

Closed
wants to merge 1 commit into from
Closed

use apollo-upload-server 6.0.0-alpha.1 #1543

wants to merge 1 commit into from

Conversation

andyrichardson
Copy link

It's not a perfect solution but moving to the latest alpha version should fix #1542.

The originating dependency issue can be found here.

/label dependencies

@apollo-cla
Copy link

@andyrichardson: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@ghost ghost added the 🎄 dependencies Updates to dependencies, generally automatically managed by Renovate. label Aug 16, 2018
@evans
Copy link
Contributor

evans commented Aug 16, 2018

@andyrichardson Thank you for the PR! I'd love to get this in, since the core-js dependency is quite annoying. Upgrading to the alpha of apollo-upload-server would necessitate removing support for Node 6 #1167, which would remove support for environments that require Node 6. If we dropped support, then we'd only be supporting a single lts version of Node, which isn't ideal. Forking apollo-upload-server and compiling to es5 could be another solution. Are there other possible fixes?

@andyrichardson
Copy link
Author

Hey @evans, I've made a request for Node 6 support on the dependent package.

In the meantime, I think a 5.0.1 release of apollo-upload-server, with core-js added to the dependencies, makes the most sense.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🎄 dependencies Updates to dependencies, generally automatically managed by Renovate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module 'core-js/modules/es7.object.entries'
3 participants