-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(apollo-engine-reporting): Add custom http agent support #1879
Merged
abernix
merged 3 commits into
apollographql:master
from
eberhara:feature/expose-engine-reporting-http-agent
Oct 26, 2018
Merged
feature(apollo-engine-reporting): Add custom http agent support #1879
abernix
merged 3 commits into
apollographql:master
from
eberhara:feature/expose-engine-reporting-http-agent
Oct 26, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eberhara
changed the title
feature(apollo-engine-reporting): Add custom http agent support to en…
feature(apollo-engine-reporting): Add custom http agent support
Oct 25, 2018
eberhara
force-pushed
the
feature/expose-engine-reporting-http-agent
branch
from
October 25, 2018 14:42
cdcd69d
to
bd6f961
Compare
4 tasks
engine: {
apiKey: 'foo',
requestAgent: proxyUrl ? new HttpsProxyAgent(proxyUrl) : undefined
}, and it works like a charm! |
eberhara
force-pushed
the
feature/expose-engine-reporting-http-agent
branch
from
October 26, 2018 11:48
bd6f961
to
831ad90
Compare
abernix
requested changes
Oct 26, 2018
eberhara
force-pushed
the
feature/expose-engine-reporting-http-agent
branch
from
October 26, 2018 13:07
831ad90
to
a94672a
Compare
eberhara
force-pushed
the
feature/expose-engine-reporting-http-agent
branch
from
October 26, 2018 13:12
a94672a
to
f66f797
Compare
@abernix updated! forgot that |
So the codecov check did not pass, however it is complaining about a file that I did not even touch. |
abernix
approved these changes
Oct 26, 2018
This should be published as |
@eberhara Where is your example code:
located? In the apollo.config.js? Or can it go in my server.js? Because I'd like to use process.env.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1836.
This PR enables developers to inject the http agent to be used on the network requests to apollo engine endpoint.
TODO: