Improve InMemoryLRUCache implementation. #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is certainly our current implementation, I'm not sure that the true spirit of an in-memory key-value store is to only map strings to other strings. While enforcing `<string, string>` might be necessary for some distributed cache stores, it seems we shouldn't enforce it for `InMemoryLRUCache`. By changing the `KeyValueCache` to default to `string` but allow other options, we can allow the user to decide exactly how the RHS of this store should be typed. This does require a bit more flexible implementation of the `length` calculator which is used for cache ejection, but that implementation will become immediately useful when we start storing parsed ASTs in this KV store.
This implements the `flush` method, which is currently supported by both Memcached and Redis, into the `InMemoryLRUCCache` cache.
Super nitty, but they are KeyValue stores, not KeyData stores.
This also re-enables the Expiration tests for this library, though I think I will continue to leave the testsuite decomposed into more granular methods for readability and future growth. Note that this doesn't implement the same default `300` second TTL as the other Memcache and Redis implementations currently do (a very debatable default we should re-consider in the future).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a number of commits which make the existing
InMemoryLRUCachemore whole. TheInMemoryLRUCache— which crutches almost entirely on the excellentlru-cachelibrary — is the currently the default cache store which is used for REST Data Sources (i.e.RESTDataSource) and persisted queries — though both of those can be provided more complex cache stores (e.g. distributed cache stores such as Redis/Memcached).In many cases though, the
InMemoryLRUCacheis an arguably less complex, yet still powerful, piece of machinery which can still be used to increase the performance of Apollo Server and seems deserving of a more consistent interface with the distributed stores. In that spirit, this PR brings:flush, vialru-cache'sresetmethod.ttlexpirations (defined duringset) vialru-cache'smaxAgeparameter.