Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Typings to @types/graphql (WIP) #215

Closed
wants to merge 3 commits into from
Closed

Changed Typings to @types/graphql (WIP) #215

wants to merge 3 commits into from

Conversation

DxCx
Copy link
Contributor

@DxCx DxCx commented Nov 20, 2016

Also, had to align to latest graphql version (0.8.2).

@DxCx
Copy link
Contributor Author

DxCx commented Nov 20, 2016

I'm stuck in a module resultion issue which i don't have much time to get into,
if someone can help that can accelerate this PR..
Basiclly, because of the lerna's linking, it looks like typescript will include typings from node_module/@types of depended packages.
this leads to duplicate identifier on graphql:

                                                                                                                                                                                    [364/97369]
2239     export { BreakingChange } from 'graphql/utilities/findBreakingChanges';
                  ~~~~~~~~~~~~~~

../graphql-server-module-operation-store/node_modules/@types/graphql/index.d.ts(2239,14): error TS2300: Duplicate identifier 'BreakingChange'.


2387     export const BreakingChangeType: {
                      ~~~~~~~~~~~~~~~~~~

../graphql-server-module-operation-store/node_modules/@types/graphql/index.d.ts(2387,18): error TS2451: Cannot redeclare block-scoped variable 'BreakingChangeType'.


2396     type BreakingChangeKey = 'FIELD_CHANGED_KIND'
              ~~~~~~~~~~~~~~~~~

../graphql-server-module-operation-store/node_modules/@types/graphql/index.d.ts(2396,10): error TS2300: Duplicate identifier 'BreakingChangeKey'.


2403     export type BreakingChange = {
                     ~~~~~~~~~~~~~~

../graphql-server-module-operation-store/node_modules/@types/graphql/index.d.ts(2403,17): error TS2300: Duplicate identifier 'BreakingChange'.


2574     const introspectionQuery: string;
               ~~~~~~~~~~~~~~~~~~

../graphql-server-module-operation-store/node_modules/@types/graphql/index.d.ts(2574,11): error TS2451: Cannot redeclare block-scoped variable 'introspectionQuery'.


2589     type IntrospectionType =
              ~~~~~~~~~~~~~~~~~

../graphql-server-module-operation-store/node_modules/@types/graphql/index.d.ts(2589,10): error TS2300: Duplicate identifier 'IntrospectionType'.


2640     type IntrospectionTypeRef =
              ~~~~~~~~~~~~~~~~~~~~

../graphql-server-module-operation-store/node_modules/@types/graphql/index.d.ts(2640,10): error TS2300: Duplicate identifier 'IntrospectionTypeRef'.


2814     class TypeInfo {
               ~~~~~~~~

../graphql-server-module-operation-store/node_modules/@types/graphql/index.d.ts(2814,11): error TS2300: Duplicate identifier 'TypeInfo'.

@helfer
Copy link
Contributor

helfer commented Nov 29, 2016

@DxCx could we solve this by updating all dependent packages that we have control over?

@DxCx
Copy link
Contributor Author

DxCx commented Dec 1, 2016

We can align typed-graphql to @types and then it might work because graphql typings won't be on @types directory.
but it looks like @types/graphql is the one to be maintained for the long run.

@Urigo , @davidyaha do you have any insights on this issue before i'm going to deep dive into it?
looks like @types/graphql is being imported from siblings packages as well for some odd reason.

@DxCx DxCx mentioned this pull request Jan 12, 2017
4 tasks
@DxCx DxCx added 🍳 breaking-change Needs to wait for a major release. tag: polish labels Jan 12, 2017
@helfer
Copy link
Contributor

helfer commented Jan 12, 2017

Closing this in favor of #260. Sorry we didn't see this PR @DxCx 😞

@helfer helfer closed this Jan 12, 2017
@DxCx DxCx deleted the DxCx-types branch January 31, 2017 15:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🍳 breaking-change Needs to wait for a major release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants